Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters support #278

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Filters support #278

wants to merge 4 commits into from

Conversation

galaxyse
Copy link

No description provided.

@cla-bot
Copy link

cla-bot bot commented Jun 23, 2023

Fresh avocado detected! Welcome and thank you for your contribution @galaxyse. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues.

/*
* DISCLAIMER
*
* Copyright 2023 Hewlett Packard Enterprise Development LP.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this should be changed according to CLA

Copy link
Collaborator

@rashtao rashtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @galaxyse , thanks for your contribution!

Unfortunately this PR has compilation errors (see https://github.com/arangodb/spring-data/actions/runs/5867038721).

From a first look, I do not fully understand the feature(s) you are trying to implement, since I cannot see any integration test, but just unit tests. I.e. it would be useful having some tests where the new annotations introduced in this PR are used. A description of the feature in the PR would be also appreciated and help updating the official documentation web pages.

Furthermore, I can only see few operators (AND and OR) and comparators (==) implemented. Is this PR still a work in progress?

From a features standpoint, some Spring Data modules already implement capabilities to apply query filters, such as:

Are any of these suitable for your needs?

Ideally, this library can be enhanced with support to any of the API mentioned above, thus avoiding implementing a new API specific for ArangoDB. Execution can be then customized, to implement specific AQL.

Best Regards

Added missing function to the file.
@galaxyse
Copy link
Author

Hi @galaxyse , thanks for your contribution!

Unfortunately this PR has compilation errors (see https://github.com/arangodb/spring-data/actions/runs/5867038721).

From a first look, I do not fully understand the feature(s) you are trying to implement, since I cannot see any integration test, but just unit tests. I.e. it would be useful having some tests where the new annotations introduced in this PR are used. A description of the feature in the PR would be also appreciated and help updating the official documentation web pages.

Furthermore, I can only see few operators (AND and OR) and comparators (==) implemented. Is this PR still a work in progress?

From a features standpoint, some Spring Data modules already implement capabilities to apply query filters, such as:

Are any of these suitable for your needs?

Ideally, this library can be enhanced with support to any of the API mentioned above, thus avoiding implementing a new API specific for ArangoDB. Execution can be then customized, to implement specific AQL.

Best Regards

Thank you for the review and response. The provided links doesn't support out needs. We need keyword based search and filtering. I have fixed the compilation issue. Can you check ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants